Walls: "Corrected" (TYPEAB=C) fs/bs bearings are treated as "Normal" bearings wrt COMPASS vs BACKCOMPASS disagree warnings

[Joe Walko]

TYPEAB=C isn't get honored when checking for compass fs/bs disagree.. Am not sure if scope is limited to just the 'disagree warning', or if the fs/bs is incorrectly processed during remaining processing.

..\walls_test_data\fsbs.srv:25:14: warning: COMPASS reading and BACKCOMPASS reading disagree by 180dg

:a1 c2 10 90/90 0

See attached files for examples, specifically second set of shots, under #PREFIX AC section.

[Joe Walko]

walls test data and walls and cavern logs

[Olly Betts]

Based on a very brief look at the code it seems to set up the equivalent of *calibrate backcompass 180. I don't see existing test coverage for this, but a simple test works in .svx data - I get no backsight warnings for:

*calibrate compass 0  
*calibrate clino 0  
*calibrate backcompass 180  
*calibrate backclino 0 -1  
*data normal from to tape compass backcompass clino backclino  
1 5a 10.00 90 90 10 10

Thanks for the examples - I'll dig into them when I have a chance.

[Olly Betts]

The problem is that INCAB currently overwrites the change which TYPEAB=C,... made (and vice versa). Either should work by itself. A very similar problem likely affects clinos.

We just need to store whether the C flag is currently active and the current INCAB value and compute the backbearing zero calibration value based on both when either changes.

[Olly Betts]

That was indeed the problem and now the reported disagreements match the diff: values in your comments:

fsbs.srv:13:12: warning: COMPASS reading and BACKCOMPASS reading disagree by 10°
 :a1 b2a 10 90/270 0 ;Az FS/BS diff:   10.0 deg, a1 to b2a ; :COMPASS reading and BACKCOMPASS reading disagree by 10dg
            ^~~~~~
fsbs.srv:16:12: warning: COMPASS reading and BACKCOMPASS reading disagree by 10°
 :a1 b3a 10 90/270 0 ;Az FS/BS diff:   10.0 deg, a1 to b3a ; COMPASS reading and BACKCOMPASS reading disagree by 10dg
            ^~~~~~
fsbs.srv:20:12: warning: COMPASS reading and BACKCOMPASS reading disagree by 10°
 :a1 b4b 10 90/280 0 ; Az FS/BS diff:   10.0 deg, a1 to b4b ; COMPASS reading and BACKCOMPASS reading disagree by 10dg
            ^~~~~~
fsbs.srv:31:12: warning: COMPASS reading and BACKCOMPASS reading disagree by 10°
 :a1 c2a 10 90/90 0 ;Az FS/BS diff:   10.0 deg, :a1 to c2a ; COMPASS reading and BACKCOMPASS reading disagree by 170dg
            ^~~~~
fsbs.srv:34:12: warning: COMPASS reading and BACKCOMPASS reading disagree by 10°
 :a1 c3a 10 90/90 0 ; Az FS/BS diff:   10.0 deg, :a1 to c3a ; COMPASS reading and BACKCOMPASS reading disagree by 170dg
            ^~~~~
fsbs.srv:39:12: warning: COMPASS reading and BACKCOMPASS reading disagree by 10°
 :a1 c4b 10 90/100 0 ; Az FS/BS diff:   10.0 deg, :a1 to c4b ; COMPASS reading and BACKCOMPASS reading disagree by 170dg
            ^~~~~~
fsbs.srv:48:19: warning: CLINO reading and BACKCLINO reading disagree by 5°
 :a1 d2a 10 90/270 -5/+5 ; Vt FS/BS diff:    5.0 deg, :a1 to d2a ; CLINO reading and BACKCLINO reading disagree by 5dg
                   ^~~~~
fsbs.srv:51:19: warning: CLINO reading and BACKCLINO reading disagree by 5°
 :a1 d3a 10 90/270 -5/+5 ; Vt FS/BS diff:    5.0 deg, :a1 to d3a ; CLINO reading and BACKCLINO reading disagree by 5dg
                   ^~~~~
fsbs.srv:55:19: warning: CLINO reading and BACKCLINO reading disagree by 5°
 :a1 d4b 10 90/270 -10/+5 ; Vt FS/BS diff:    5.0 deg, :a1 to d4b ; CLINO reading and BACKCLINO reading disagree by 5dg
                   ^~~~~~
fsbs.srv:62:19: warning: CLINO reading and BACKCLINO reading disagree by 5°
 :a1 e2a 10 90/270 +5/+5 ; Vt FS/BS diff:    5.0 deg, :a1 to e2a ; CLINO reading and BACKCLINO reading disagree by 5dg
                   ^~~~~
fsbs.srv:65:19: warning: CLINO reading and BACKCLINO reading disagree by 5°
 :a1 e3a 10 90/270 +5/+5 ; Vt FS/BS diff:    5.0 deg, :a1 to e3a ; CLINO reading and BACKCLINO reading disagree by 5dg
                   ^~~~~
fsbs.srv:69:19: warning: CLINO reading and BACKCLINO reading disagree by 5°
 :a1 e4b 10 90/270 0/+5 ; Vt FS/BS diff:    5.0 deg, :a1 to e4b ; CLINO reading and BACKCLINO reading disagree by 5dg
                   ^~~~

A very similar problem likely affects clinos.

They don't suffer from the same problem since INCVB sets the zero error but TYPEVB=C,... sets the scale to -1 (which flips the order), whereas for the compass both INCAB and TYPEAB set the zero error and so overwrite one another's changes.

I should double check that the order the clino corrections are applied in matches what we actually need for Walls though.

[Joe Walko]

The problem is that INCAB currently overwrites the change which TYPEAB=C,... made (and vice >>versa). Either should work by itself. A very similar problem likely affects clinos

Ah; so same root cause as #162. I didn't make the connection between TYPEAB vs INCAB in this one (161), and didn't think to re-test it once I saw TYPEAB affecting INCAB in 162 (which took me longer than it should have to narrow down - too much data in my dataset).

In a bit of irony, I resorted to having claude crank out a parser for the cavern Walls parser logfile :-), to make it easier to compare your parser warnings against shot-data output from the parser in my screener. I then noticed lots of, um, disagreements between reported fs/bs disagreements.

Most all our surveys have INCA/INCAB - standard practice, set based on "compass course" readings. And, several hundred surveys with TYPEAB, multiple shots per survey, for course, probably equaling around ~1,000 inflated cavern fs/b disagreement warnings.