About box photo missing on OS X

[Olly Betts]

Phil Maynard reports that on 10.6.8 the about dialog throws up an assertion failure when opened:

../src/osx/core/bitmap.cpp(1501): assert "IsOK()" failed in GetHeight(): invalid bitmap

If you answer "No" to "Do you want to stop the program?" you get the about dialog, but the cave image is missing (only image is the aven icon).

This sounds like it is failing to load aven-about.png - most of the code just quietly handles that, but the minimum height for the sizer is unconditionally set to the height of the bitmap. If I delete this image on Linux, I get the same assertion, so I've fixed that part in commit [4c0a0a22e7b890c84e2c1da4e182e5212ee1aa53/git].

That leaves the question of why the image is failing to load. I tested the about dialog worked on OS X at some point between 1.2.18 and 1.2.19, and didn't get this assertion, so it may be related to the OS X version, or to changes after that.

[Olly Betts]

Jenny tested 1.2.26 and the image appears, thought that's with a more modern version of OS X.

So either this is fixed, or it's specific to older OS X.

[Olly Betts]

Phil Maynard checked 1.2.26 on OS X 10.6.8, and the image is still missing there.

The assertion is gone though, and since the image is just decorative this is now purely a cosmetic issue.

[Olly Betts]

Realistically a missing decorative image on an OS X version which Apple officially no longer support isn't going to get fixed, so I'm just going to close this as "wontfix". If someone wants to debug it and come up with a clean patch to fix it, I'd happily apply it such a patch.