Custom Query (95 matches)

Hi, therion uses img.h and img.c, and when I compile and run therion with Undefined Behavior Sanitizer, this error appears:

UndefinedBehaviorSanitizer: undefined-behavior
../extern/img.c:103:27: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'

Problem is in function get32(), where shifting of signed value by 24 bits interferes with a sign bit. Bitwise operations should be done with unsigned types.

Therion CI job where this error occured: ​https://github.com/Afforix/therion/runs/2025117514?check_suite_focus=true.

The manual has 'cypolar' instead of 'cylpolar' in one place.

This patch fixes it: commit 9a6a2039059a3266c72493266e6027234b6c1213 (HEAD -> dgit/sid) Author: Wookey <wookey@…> Date: Tue Jul 14 20:00:42 2020 +0100

Fix typo in doc 'cypolar'->'cylpolar'

diff --git a/doc/manual.sgml b/doc/manual.sgml index 54d07f6..af42fda 100644 --- a/doc/manual.sgml +++ b/doc/manual.sgml @@ -1744,7 +1744,7 @@ A CYLPOLAR style survey is very similar to a diving surv$

is always measured horizontally rather than along the slope of the leg.

<programlisting>

-*data cypolar from to tape compass fromdepth todepth +*data cylpolar from to tape compass fromdepth todepth

1 2 9.45 311 -13.3 -19.0</programlisting>

<programlisting>

Jenny was unable to get terrain to load, instead just getting a grey disk at altitude 0. I've fixed the error checking for 1.2.20, so it now actually fails, but the inability to load terrain remains. My attempts to debug suggest that the wxZipInputStream class always fails to read anything, returning an unhelpful "generic read error".