Changeset e6312c0 in git

Timestamp:

27/01/14 11:14:59 (6 years ago)

Author:

Olly Betts <olly@…>

Branches:

line_contents, master, stereo, travis-osx

Children:

8c1d295

Parents:

bd2e33a

Message:

make_release: Add simple check for comments in C sources.
make_release: Before release, build with -Werror to catch any
warnings which may have been missed.

Files:

• ChangeLog (modified) (1 diff)
• make_release (modified) (2 diffs)

ChangeLog

@@ +1 @@
+Mon Jan 27 11:13:31 GMT 2014  Olly Betts <olly@survex.com>
+
+        * make_release: Add simple check for // comments in C sources.
+        * make_release: Before release, build with -Werror to catch any
+          warnings which may have been missed.
+
 Mon Jan 27 10:25:02 GMT 2014  Olly Betts <olly@survex.com>
 

make_release

@@ -10 +10 @@
 
 if test x"$rel" = xyes ; then
+  cd src
+  perl -ne 'if (m!(.*)//! && $1 !~ / \* /) {print "$ARGV:$.:// comment in C source\n"; exit 1}' \
+      *.c \
+      cavern.h commands.h cmdline.h date.h datain.h debug.h\
+      filelist.h filename.h getopt.h hash.h img.c img.h img_hosted.h ini.h\
+      listpos.h matrix.h message.h namecmp.h netartic.h netbits.h\
+      netskel.h network.h osalloc.h osdepend.h ostypes.h out.h readval.h str.h\
+      useful.h validate.h whichos.h
+  cd ..
+
   # Check there are no uncommitted changes.
   if git commit -a --dry-run >/dev/null 2>/dev/null ; then
@@ -24 +34 @@
   mv INSTALL.keep INSTALL
   ./configure CC=gcc CXX=g++
+  make CFLAGS='-Werror' CXXFLAGS='-Werror'
   make distcheck
-  # FIXME: setting c89 doesn't define unix and suppresses getc_unlocked().
-  # Tell the preprocessor to be C89 - this makes it reject // comments
-  # FIXME -Werror makes configure explode CFLAGS="-Werror -Wp,-std=c89"
-  # FIXME   CXXFLAGS="-Werror"
 else
   make dist